Ultrasaurus

add link to github pages

Ultrasaurus

ignore templates in nested folders (for examples), removed unused audio formatting in default template

Ultrasaurus

play audio in-line, use AwesomeFont, push demo to gh pages

Ultrasaurus

add FontAwesome play icon

Ultrasaurus

don't track webgen-generated folders

Ultrasaurus

play audio inline, show '#' for links w/o text

Ultrasaurus

specify that links are to audio/mp3 files

Ultrasaurus

add different mimetype for audio files

Ultrasaurus

list the correct mimetype (not file extension!)

Ultrasaurus

don't ignore markdown folder in git

Ultrasaurus

test ogg & wav files. (tested w/lynx and Chrome)

Ultrasaurus

Create github_actions.yml

Ultrasaurus

add .cargo/bin to path, run webgenr

Ultrasaurus

test workflow to upload to github spaces

Ultrasaurus

test quick fix - remove github-ref

Ultrasaurus

Update Cargo.toml about what is significant about this version.

Ultrasaurus

update source path for GitHub pages artifact

Ultrasaurus

use upload-pages-artifact to deploy example

Ultrasaurus

debug stuff for Actions

test different path, add debug info to figure out where this code is running

Ultrasaurus

do everything in one flow

having things in different (logical) categories may have been the problem with losing state between groups of steps.

Ultrasaurus

move environment: to a job in YAML

Ultrasaurus

don't .gitignore the templates folder

Ultrasaurus

fix type-o

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

I assumed CSS with padding and maybe a circle around the triangle (which can be done with pure css or FontAwesome has a circle-play glyph

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

we need templates directory at the root, since those files are what are accessed by RustEmbed and used to auto-populate a new project

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

it's not about memory leak, but rather best practice is to avoid allocations for performance, but I also believe in doing benchmarks and letting performance optimizations come from actual slow spots

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

I'm testing it using an npm package https://github.com/lwsjs/local-web-server

ws -d _website 

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

not a show stopper, but I find it helpful (for now at least) to include a comment about what is significant about this version

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

why this?

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

I think ideally this would avoid allocating a String, since we only use the extension to generate a mimetype, though ok to check in as is and iterate later :)

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

likewise, I think this should return a &str or Cow rather than allocating a String that might not be needed by the caller

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

Ultrasaurus

v0.1.9

• play audio in-line in supported browsers
• use AwesomeFont "play" button for audio links in other browsers
• added tests for Wav, Ogg files

Ultrasaurus

running locally, I get this error in the browser console:

 GET http://localhost:8000/favicon.ico 404 (Not Found) 

puzzled since I see no reference to a favicon and also cannot repro in main

Ultrasaurus

notes on dependencies in README

Ultrasaurus

create vertical-banner layout, remove empty right column from base layout for now

Ultrasaurus

I made a fork and attempted to contribute using codespaces. I couldn't figure out how to modify the codespace to use the correct version of ruby. Does anyone know how to do this?

$ ruby --version
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux] 

The project requires 2.6.3 And my guess is this is why I get errors when I try to build the website.

Ultrasaurus

hmm, I assumed we could set that up in a fork... weird that it would need to be in the original repo, but maybe that's a good idea anyhow!

Ultrasaurus

experimental

Ultrasaurus

small refector: repeated code -> function

Ultrasaurus

copy non-hbs files from embedded templates

Ultrasaurus

v0.1.8 copy non-hbs files in templates (recursively)

Ultrasaurus

this fails and I don't know how to fix:

Airtemis:quick-xml sallen$ cargo run --example read_nodes_serde --features="serialize"
   Compiling quick-xml v0.26.0 (/Users/sallen/src/rust/ref/quick-xml)
    Finished dev [unoptimized + debuginfo] target(s) in 1.26s
     Running `target/debug/examples/read_nodes_serde`
[examples/read_nodes_serde.rs:71] "{:?}" = "{:?}"
[examples/read_nodes_serde.rs:71] &config = Config {
    settings: DefaultSettings {
        language: "es",
        greeting: "HELLO",
    },
    translation: [
        Translation {
            tag: "",
            lang: "",
            text: "",
        },
    ],
}
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `4`', examples/read_nodes_serde.rs:76:5 

Ultrasaurus

Updated example works now! Thanks so much for helping me understand how to fix it. I think I've addressed all the feedback.

Ultrasaurus

this fails and I don't know how to fix:

Airtemis:quick-xml sallen$ cargo run --example read_nodes_serde --features="serialize"
   Compiling quick-xml v0.26.0 (/Users/sallen/src/rust/ref/quick-xml)
    Finished dev [unoptimized + debuginfo] target(s) in 1.26s
     Running `target/debug/examples/read_nodes_serde`
[examples/read_nodes_serde.rs:71] "{:?}" = "{:?}"
[examples/read_nodes_serde.rs:71] &config = Config {
    settings: DefaultSettings {
        language: "es",
        greeting: "HELLO",
    },
    translation: [
        Translation {
            tag: "",
            lang: "",
            text: "",
        },
    ],
}
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `4`', examples/read_nodes_serde.rs:76:5 

Ultrasaurus

nice suggestion. done!

Ultrasaurus

this fails and I don't know how to fix:

Airtemis:quick-xml sallen$ cargo run --example read_nodes_serde --features="serialize"
   Compiling quick-xml v0.26.0 (/Users/sallen/src/rust/ref/quick-xml)
    Finished dev [unoptimized + debuginfo] target(s) in 1.26s
     Running `target/debug/examples/read_nodes_serde`
[examples/read_nodes_serde.rs:71] "{:?}" = "{:?}"
[examples/read_nodes_serde.rs:71] &config = Config {
    settings: DefaultSettings {
        language: "es",
        greeting: "HELLO",
    },
    translation: [
        Translation {
            tag: "",
            lang: "",
            text: "",
        },
    ],
}
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `4`', examples/read_nodes_serde.rs:76:5 

Ultrasaurus

Ultrasaurus

add newline at end, per code review

Ultrasaurus

revert change that added anyhow, not needed anymore

Ultrasaurus

example works

Ultrasaurus

use rename_all

Ultrasaurus

demonstrate for accessing inner text

Ultrasaurus

experimental