Microsoft-github-policy-service

Pull request has been created with Komac v1.11.0 :rocket:

Microsoft Reviewers: Open in CodeFlow

Microsoft-github-policy-service

eitsupi,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

LilyWangLL

[imgui-sfml] Update to 2.6

JohnMcPMS

Log Com invocation startup telemetry and delay auto update time when invoked from explorer (#3665) (#3684)

• Add telemetry event for PackageManager class creation
• Delay source update time to 7 days by default when invoked from explorer
• Also fixes Source agreements related crash found when doing the above work

Co-authored-by: yao-msft [email protected]

JohnMcPMS

Cherry pick 3665 into 1.6

Zhifanwu

started

JohnMcPMS

Add a bit of randomness to the wait time after source update failure (#3661) (#3683)

JohnMcPMS

Cherry pick 3661 into 1.6

Chjinche

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [x] The pull request does not introduce [breaking changes]
• [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [x] I have read the contribution guidelines.

General Guidelines and Best Practices

• [x] Title of the pull request is clear and informative.
• [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [x] Pull request includes test coverage for the included changes.

Screen Shot in VsCode

Tests

Chjinche

A more common way to assert exception is `pytest.raises(<Exception>)`. You could refer to https://github.com/microsoft/promptflow/blob/6f767704eca7ac8f8bdea6a9b75931a463753c81/src/promptflow-tools/tests/test_common.py#L43C1-L46C68

Chjinche

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [x] The pull request does not introduce [breaking changes]
• [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [x] I have read the contribution guidelines.

General Guidelines and Best Practices

• [x] Title of the pull request is clear and informative.
• [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [x] Pull request includes test coverage for the included changes.

Screen Shot in VsCode

Tests

Chjinche

Maybe could add conditions like `isinstance(connection, OpenAIConnection)` to replace `try-except`

Chjinche

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [x] The pull request does not introduce [breaking changes]
• [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [x] I have read the contribution guidelines.

General Guidelines and Best Practices

• [x] Title of the pull request is clear and informative.
• [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [x] Pull request includes test coverage for the included changes.

Screen Shot in VsCode

Tests

Chjinche

Chjinche

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [x] The pull request does not introduce [breaking changes]
• [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [x] I have read the contribution guidelines.

General Guidelines and Best Practices

• [x] Title of the pull request is clear and informative.
• [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [x] Pull request includes test coverage for the included changes.

Screen Shot in VsCode

Tests

Chjinche

Maybe you need to add a new connection named like `gpt2_connection` instead of modifying previous one?

Chjinche

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [x] The pull request does not introduce [breaking changes]
• [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [x] I have read the contribution guidelines.

General Guidelines and Best Practices

• [x] Title of the pull request is clear and informative.
• [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [x] Pull request includes test coverage for the included changes.

Screen Shot in VsCode

Tests

Chjinche

JohnMcPMS

Improve packaged source updating (#3657) (#3682)

This change refactors the index package updating to enable an optimization; using an HTTP header to determine the available version rather than reading the package contents remotely. If the header is present, containing a valid package version string, it will be used as the available version. If not, the existing package content examination will be used.

The refactoring was required to do all package inspection steps after downloading the package, rather than before. This enables the single version value to be sufficient until we decide to update, and then in the very unlikely event of the package not meeting criteria we will delete it after having downloaded it.

JohnMcPMS

Cherry pick 3657 to 1.6

Sekkit

started

Lubaihua33

Try to reset password when running sudo command requires password

Sylvanc

Update for the new trieste driver code

Ethermeta-org

DeepSpeed is a deep learning optimization library that makes distributed training and inference easy, efficient, and effective.

Masami10

started

Skottmckay

Read model zoo test (#17666)

Skottmckay

Fix ARMv7 build (#13891)

Fix ARMv7 build error on Linux.

Description

cpuinfo_* functions are only available if CPUINFO_SUPPORTED set and therefore "cpuinfo.h" included. Fixed with extended conditional code.

Motivation and Context

Compilation with ARMv7 on Linux system fails.

Skottmckay

[QNN EP] Integrate Resize op fixes from QNN 2.14.1 (#17641)

Description

QNN SDK version 2.14.1 fixed several issues with the QNN Resize operator. This PR integrates the fixes and simplifies the implementation.

Motivation and Context

Improve Resize operator and test coverage.

Skottmckay

[WebNN EP] Remove workaround for dynamic shape (#17644)

As now we have the FreeDimensionOverrides option to support dynamic shape, we can remove the previous workaround.

Skottmckay

[ROCm] Remove ROCm5.4.2, ROCm 5.5 and add ROCm5.7 to python package pipeline (#17668)

• Remove ROCm5.4.2, ROCm 5.5 and add ROCm5.7 to python package pipeline

• Remove redundant arg

Skottmckay

[js/web] configure 5GB memory space for webpack build (#17684)

Description

ort-web build step - webpack consumes the amount of memory on the edge of Node.js(V8)'s default max-old-space-size, so increase the default memory size to 5GB to avoid this issue.

Skottmckay

Fix static quantization for QDQ and Percentile distribution (#17649)

Description

One quantization case was not covered by the current list of unit tests. This PR adds a unit test to cover that case with the fix. It fixes the issue #17619.

Motivation and Context

Skottmckay

[JSEP] allow JsCustomAllocator to deal with zero sized input (#17660)

Description

allow JsCustomAllocator to deal with zero sized input.

This is a standalone fix for zero-sized tensor handling for JsCustomAllocator. There are other components in JSEP not supporting zero-sized tensors need to be fixed.

Skottmckay

[JSEP] allow DataTransfer to deal with zero sized input (#17661)

Description

allow DataTransfer to deal with zero sized input.

This is a standalone fix for zero-sized tensor handling for JSEP DataTransfer. There are other components in JSEP not supporting zero-sized tensors need to be fixed.

Skottmckay

[js/web] update browser launch cmd flags (#17658)

Description

update Chromium browser launch command line flags

Canary already using dxc so no need to specify '--enable-dawn-features=use_dxc' for canary.

Skottmckay

Update nodejs to 18.x (#17657)

1. Upgrade nodejs from 16.x to 18.x for Windows pipelines
2. Avoid using Azure DevOps "NodeTool" on Linux. The tool installs nodejs from internet or local disk cache. But we already moved all Linux tests to docker. So we do not need the installer anymore.
3. Remove some other unused code.

Skottmckay

Update quant_utils.py/write_calibration_table (#17314)

Skottmckay

[On-Device Training] Expose Parameters through the Training API (#17364)

Skottmckay

[java] Enable output pinning in OrtSession and OrtTrainingSession (#16835)

Skottmckay

[TensorRT EP] Back out the PerThreadContext (#17690)

Current TRT EP's PerthreadContext allows more than one IExecutionContext instance to be created by one engine instance. But, it's possible to hit an error that caused by TRT API context.setBindingDimensions() in our TRT EP code here under the case of the input shape changes ( meaning engine being rebuilt) with multithreading. From the doc and the discussion, it seems we should have different OptimizationProfile for different IExecutionContext which our current TRT EP doesn’t support regardless of using PerThreadContext implementation. Back out the PerThreadContext until we completely solve this issue.

Skottmckay

Stop throwing exception on python binding when multiple EP available (#17659)

Stop throwing the exception when the provider list is empty but there are multiple available EPs. Other language bindings throw no exception at all, this change will align them up.

---

Co-authored-by: Randy Shuai [email protected]

Skottmckay

Close the JSON object in settings.json (#17583)

Description

This patch adds a closing curly bracket at the end of settings.json.

Motivation and Context

settings.json is just not closed. It was accidentally removed at 4e6ea730d633756e9e04df8968304d11a575dde4

Skottmckay

fixed #16873 (#16932)

Skottmckay

Enabling c++ 20 in MacOS build (#16187)

Description

Motivation and Context

Skottmckay

Add prepacked weights container to subgraphs (#17671)

Description

Adds prepacked weights container to model subgraphs.

Motivation and Context

Allows for initializer sharing when the initializers are located in subgraphs. I encountered this bug when attempting to share weights between T5 BeamSearch models where the shareable initializers are located in the encoder and decoder subgraphs and it failed to reduce memory usage.

Sylvanc

disable typeinfer pass, WIP

YingChen1996

Description

build result:

double click app.exe:

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [ ] The pull request does not introduce [breaking changes]
• [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

• [ ] Title of the pull request is clear and informative.
• [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [ ] Pull request includes test coverage for the included changes.

YingChen1996

YingChen1996

Description

build result:

double click app.exe:

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

• [ ] The pull request does not introduce [breaking changes]
• [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
• [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

• [ ] Title of the pull request is clear and informative.
• [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• [ ] Pull request includes test coverage for the included changes.

YingChen1996

you mean `flow`: the folder contains all the flow files. ? I just keep the format as other deploy doc.

Zhenlan

Zhenlan

What happens if the Seed is not specified? Do we use a default value?

Zhenlan

Zhenlan

MonicaLiu0311

• updated to 3.4.2
• removed ports/mygui/Use-vcpkg-sdl2.patch because upstream now performs similar step to link SDL2
• removed fix-osx.patch since it was accepted to the upstream repo
• fixed wasm32-emscripten build

while 3.4.3 is already out, it's quite different in some parts. I'm working on a project that doesn't compile with 3.4.3. I guess we should accept 3.4.2 first.

MonicaLiu0311

An error occurred while testing features on x64-windows-static:

./vcpkg install mygui[*]:x64-windows-static

...

-- Configuring x64-windows-static
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v
    Working Directory: G:/mygui/buildtrees/mygui/x64-windows-static-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      G:\mygui\buildtrees\mygui\config-x64-windows-static-dbg-CMakeCache.txt.log
      G:\mygui\buildtrees\mygui\config-x64-windows-static-rel-CMakeCache.txt.log
      G:\mygui\buildtrees\mygui\config-x64-windows-static-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
  ports/mygui/portfile.cmake:31 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include) 

G:\mygui\buildtrees\mygui\install-x64-windows-dbg-out.log:

-- Configuring MYGUI 3.4.2
-- Found Freetype: optimized;G:/mygui/installed/x64-windows-static/lib/freetype.lib;debug;G:/mygui/installed/x64-windows-static/debug/lib/freetyped.lib (found version "2.12.1") 
-- Found ZLIB: optimized;G:/mygui/installed/x64-windows-static/lib/zlib.lib;debug;G:/mygui/installed/x64-windows-static/debug/lib/zlibd.lib (found version "1.3.0")  
-- Found BZip2: optimized;G:/mygui/installed/x64-windows-static/lib/bz2.lib;debug;G:/mygui/installed/x64-windows-static/debug/lib/bz2d.lib (found version "1.0.8") 
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found
-- Found PNG: optimized;G:/mygui/installed/x64-windows-static/lib/libpng16.lib;debug;G:/mygui/installed/x64-windows-static/debug/lib/libpng16d.lib (found version "1.6.39") 
-- Could NOT find SDL2 (missing: SDL2_LIBRARY) (found version "2.28.3")
-- Could NOT find SDL2_image (missing: SDL2_IMAGE_LIBRARIES) (found version "2.6.3")
CMake Deprecation Warning at CMake/Dependencies.cmake:56 (cmake_policy):
  The OLD behavior for policy CMP0072 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:189 (include)


-- Found OpenGL: opengl32  found components: OpenGL 
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- 
-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
+ freetype
+ opengl
-----------------------------------------------------------------------------
-- The following OPTIONAL packages could NOT be located on your system.
-- Consider installing them to enable more features from this software.
+ Doxygen: Tool for building API documentation <http://doxygen.org>
-----------------------------------------------------------------------------

-- Found OpenGL: opengl32   
-- Configuring done (5.2s)
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
SDL2_IMAGE_LIBRARY (ADVANCED)
    linked by target "EditorFramework" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/EditorFramework
    linked by target "LayoutEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/LayoutEditor
    linked by target "SkinEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/SkinEditor
    linked by target "ImageEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/ImageEditor
    linked by target "FontEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/FontEditor
SDL2_LIBRARY (ADVANCED)
    linked by target "EditorFramework" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/EditorFramework
    linked by target "LayoutEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/LayoutEditor
    linked by target "SkinEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/SkinEditor
    linked by target "ImageEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/ImageEditor
    linked by target "FontEditor" in directory G:/mygui/buildtrees/mygui/src/MyGUI3.4.2-2a0c5de7a4.clean/Tools/FontEditor

-- Generating done (0.2s)
CMake Warning:
  Manually-specified variables were not used by the project:

    FETCHCONTENT_FULLY_DISCONNECTED
    _VCPKG_ROOT_DIR


CMake Generate step failed.  Build files cannot be regenerated correctly. 

Zhenlan

Zhenlan

I would avoid mentioning the targeting filter here. It may confuse customers. It may be helpful, at the end of this section, to explain why the allocation is different from the targeting filter.

Zhenlan

Zhenlan

Sha256feng

started